Add SentenceInfo.msg and WordInfo.msg #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sktometometo
reviewed
Apr 4, 2022
| @@ -0,0 +1,2 @@ | |||
| Header header | |||
There was a problem hiding this comment.
What kind of use are you planning for header of SentenceInfo.msg?
sktometometo
reviewed
Apr 4, 2022
| # please see below URL for more details. | ||
| # https://cloud.google.com/speech-to-text/docs/reference/rest/v1/speech/recognize#wordinfo | ||
| float64 start_time | ||
| float64 end_time |
There was a problem hiding this comment.
startTime and endTime of original WordInfo are Duration (formatted string). I think duration is more compatible to it than float64.
sktometometo
suggested changes
Apr 4, 2022
| # please see below URL for more details. | ||
| # https://cloud.google.com/speech-to-text/docs/reference/rest/v1/speech/recognize#wordinfo | ||
| float64 start_time | ||
| float64 end_time |
There was a problem hiding this comment.
start_time is duration from the initial time of sentences to the start of the word. This is not clear from the field name itself.
Please add field description or change field name in order to make target use of each field clear to users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
Google speech-to-text provide
WordInfowhich hasstart_time,end_time,confidenceandspeaker_tagfor each words.For more details, please see https://cloud.google.com/speech-to-text/docs/reference/rest/v1/speech/recognize#wordinfo .
This PR adds
WordInfo.msgandSentenceInfo.msgand addsSentenceInfo.msgtoSpeechRecognitionCandidate.msg.